conda-forge / gap-feedstock

A conda-smithy repository for gap.
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

Install GAP documentation #72

Closed fingolfin closed 1 year ago

fingolfin commented 1 year ago

Checklist

Resolves #70

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

fingolfin commented 1 year ago

Since the size of the manual was mentioned before: if that's a concern, it would be good to know what the rules are resp. what is acceptable and what not.

Regarding "users won't know where to find the documentation": many users known about the GAP user preference HelpViewers which can be changed to display the help via a HTML or PDF viewer. These users do not need know the file locations, GAP knows them.

isuruf commented 1 year ago

We can try this and move the docs to a separate package if the size becomes a problem

isuruf commented 1 year ago

Thanks

fingolfin commented 1 year ago

Out of genuine curiosity, in which way might the size become a problem? Are there some hard coded limits in the Conda software stack the limit the size of a package? I would have thought that there are software packages considerably larger than GAP, but thinking about this again now I admit all examples that come to mind are commercial (such as Mathematica). Or is it more a concern that some users might complain why Conda uses so much disk space? Or something else?

Anyway, if you need to reduce the size, I would recommend to first and only delete the PDFs, as they add to quite a bit, and it is fairly easy to just remove them (just remove all files with extension .pdf inside the GAP tree)

isuruf commented 1 year ago

Or is it more a concern that some users might complain why Conda uses so much disk space?

This one. For eg: the sage installation is quite large and takes a while to download and gap package getting bigger will add to the time to download and install sage.