Fix usage of Gazebo plugins as linked libraries on macOS

conda-forge / gazebo-feedstock

A conda-smithy repository for gazebo.

BSD 3-Clause "New" or "Revised" License

9 stars 8 forks source link

Fix usage of Gazebo plugins as linked libraries on macOS #218

Closed traversaro closed 3 months ago

traversaro commented 3 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 3 months ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 3 months ago

Should we use a glob instead? Anything with plugin in the name?

traversaro commented 3 months ago

Should we use a glob instead? Anything with plugin in the name?

I think more and less everything in the $PREFIX/lib/gazebo-11/plugins folder has plugin in its name, so we could just iterate on the directory content. However, to reduce the chance of clobbering I would just keep that list, that is the one we actually need for gazebo-ros-plugins.

Tobias-Fischer commented 3 months ago

Great, thanks for the explanation!