search

conda-forge / gdal-feedstock

A conda-smithy repository for gdal.
BSD 3-Clause "New" or "Revised" License
30 stars 63 forks source link

Rebuild for libarrow 15 #885

Closed regro-cf-autotick-bot closed 8 months ago

regro-cf-autotick-bot commented 8 months ago

This PR has been triggered in an effort to update arrow_cpp15.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7758045073, please use this URL for debugging.

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

rouault commented 8 months ago

hum, we'd actually need to pick-up commits https://github.com/OSGeo/gdal/commit/36ae99be74ef899818606b346f8f113f5ac880be and https://github.com/OSGeo/gdal/commit/289283a73cddda7f041139bd1bdaf8a7cfefe2c2 for libarrow 15 compatibility

akrherz commented 8 months ago

Thanks @rouault , will check that CI fails first and then work to bring patches with those commits.

rouault commented 8 months ago

will check that CI fails first and then work to bring patches with those commits.

CI won't probably fail. The failures are when turning warnings as errors, and at runtime. Well, this might be more a theorertical concern than a practical one, as the runtime error would only occur if opening files with the new Arrow types, and the ecosystem is just slowly embracing them (I actually dislike their introduction)

akrherz commented 8 months ago

Thanks again and yeah, CI didn't fail. I brought your two commits in now and they appeared to cleanly apply locally.