conda-forge / gdal-feedstock

A conda-smithy repository for gdal.
BSD 3-Clause "New" or "Revised" License
30 stars 63 forks source link

Fix libgdal-pdf that fails to work #975

Closed rouault closed 2 months ago

rouault commented 2 months ago

due to poppler not being found when building libgdal-core

which causes the plugin to emit the following and not being functional:

Warning 1: Driver PDF declares DMD_OPENOPTIONLIST whereas its proxy doesn't declare it or with a different value
Warning 1: Driver PDF declares DCAP_OPEN whereas its proxy doesn't declare it or with a different value
Warning 1: Driver PDF declares DMD_SUBDATASETS whereas its proxy doesn't declare it or with a different value
Warning 1: Proxy driver PDF declares a pfnIdentify callback whereas the real driver does not.
Warning 1: Driver PDF declares a pfnOpen callback whereas its proxy doest not declare DCAP_OPEN
conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

akrherz commented 2 months ago

poppler was one of the main things that drove #722. Does poppler just need to be present at build time and not at run?

rouault commented 2 months ago

Does poppler just need to be present at build time and not at run?

just at build time. Technically it doesn't even need to be there. Just having -DHAVE_POPPLER in CXXFLAGS of libgdal-core should be enough

akrherz commented 2 months ago

just at build time.

I believe adding it as a dep will cause it to be added as a run dep, unless we do some tricks. Will research this more soon and hopefully I am wrong :)

rouault commented 2 months ago

Technically it doesn't even need to be there. Just having -DHAVE_POPPLER in CXXFLAGS of libgdal-core should be enough

trying that approach in https://github.com/conda-forge/gdal-feedstock/pull/976

xylar commented 2 months ago

I believe adding it as a dep will cause it to be added as a run dep, unless we do some tricks.

I don't think so. I didn't see any run_exports: https://github.com/conda-forge/poppler-feedstock/blob/main/recipe/meta.yaml

akrherz commented 2 months ago

Can a simple test be added to the libgdal-pdf artifact section to ensure that it is working?

rouault commented 2 months ago

Can a simple test be added to the libgdal-pdf artifact section to ensure that it is working?

attempted in #976 with 41f671383fa4ab65fdf7bc4fb66faaf0bf6ede0b

rouault commented 2 months ago

closing as superseded per #976