conda-forge / gdal-feedstock

A conda-smithy repository for gdal.
BSD 3-Clause "New" or "Revised" License
30 stars 62 forks source link

Convert recipe (on hold) #978

Open rouault opened 2 weeks ago

rouault commented 2 weeks ago

Cf https://prefix.dev/blog/rattler_build_on_conda_forge

Checklist

rouault commented 2 weeks ago

@conda-forge-admin, please rerender

conda-forge-webservices[bot] commented 2 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

This is a rattler-build recipe and not yet lintable. We are working on it!

github-actions[bot] commented 2 weeks ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/10639353086.

rouault commented 2 weeks ago

hum conda-smithy doesn't seem happy with the removal of recipe/meta.yaml. I might have missed something in the blog post

akrherz commented 2 weeks ago

pushed a suspected change needed

@conda-forge-admin please rerender

github-actions[bot] commented 2 weeks ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/10641099586.

akrherz commented 2 weeks ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 weeks ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/10641163183.

akrherz commented 2 weeks ago

I got things a bit further along, but now am unsure what is needed to be done.

 ╭─ Finding outputs from recipe
 │
 ╰─────────────────── (took 0 seconds)
Error:   × Parsing: invalid field `requirements`.
    ╭─[24:1]
 23 │ 
 24 │ requirements:
    · ──────┬─────
    ·       ╰── here
 25 │   build:
    ╰────
  help: multi-output recipes cannot have a top-level requirements field.
        Move `requirements` inside the individual output.
xylar commented 2 weeks ago

It sounds like we no longer need the redundant requirements at the top of the recipe.yaml. That's a nice change!

xylar commented 2 weeks ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 weeks ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/10643835380.

xylar commented 2 weeks ago

This seems like it's going to be a slog. There are a lot of changes required to get this to render. For example,

    build:
      ignore_run_exports_from:
        - expat

needs to become:

    requirements:
      ignore_run_exports:
        from_package:
          - expat

in a bunch of places. The tests: bit at outside of outputs: needs to go.

rattler-build is also pretty unhappy with:

{{ \".\".join(version | split(\".\")[:2]) }}"

but I couldn't figure out a way to move this to context: that made it happy.

xylar commented 2 weeks ago

It seems like we might want to hold off on this until some simpler recipes can point the way. This is an unusually complex feedstock and probably a really good test of the robustness of rattler-build but maybe not a good choice for early adoption.

Also, see: https://github.com/conda-forge/pyremap-feedstock/pull/25#issuecomment-2322848607 https://github.com/conda-forge/conda-smithy/issues/2047 https://github.com/conda-forge/conda-smithy/issues/2047#issuecomment-2322848344

wolfv commented 2 weeks ago

Thanks both for working on this. Indeed, GDAL will be a good test case and we are more than happy to tackle it, but we should probably indeed follow @xylar's suggestion and tackle a few easier feedstocks first :)