geckodriver 0.27.0 - Githubissues

conda-forge / geckodriver-feedstock

A conda-smithy repository for geckodriver.

BSD 3-Clause "New" or "Revised" License

2 stars 5 forks source link

geckodriver 0.27.0 #11

Closed bollwyvl closed 4 years ago

bollwyvl commented 4 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.
- [x] applies license-checking approach from pysyntect-feedstock

Awaiting confirmation of source commit and firefox support pin from https://github.com/mozilla/geckodriver/issues/1753

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [47]

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 4 years ago

Hooray passing tests with no VW flags!

I'd like to get the firefoxen testing with 0.26.0 first, then put the downstream section back in, and then will feel good about merging this. Looking to roll out the PDF stuff that works with ff 79+ as a separate test, as that's a really big deal for me.

bollwyvl commented 4 years ago

going to give this a crack with vendored tests from conda-forge/firefox-feedstock#26, but may well just tear it all out and replace it with downstream for simplicity...

bollwyvl commented 4 years ago

Aw, shoot. There's the whole licenses for static-everything issues. Will adapt approach from pysyntect-feedstock.

bollwyvl commented 4 years ago

Kind of tired of working on this after hunting down its 272 dependency licenses... it's working fine against ff 79, and don't feel like push much further to get 68/78 fully tested here.