Inc cdt name cos7 - Githubissues

conda-forge / geckodriver-feedstock

A conda-smithy repository for geckodriver.

BSD 3-Clause "New" or "Revised" License

2 stars 5 forks source link

Inc cdt name cos7 #15

Closed bollwyvl closed 3 years ago

bollwyvl commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.
- [x] added httpdate
contains #14 (and probably #13)
- i still haven't run down what the underlying issue is (probably my fault, of course), but if it's just licenses blocking it...

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 3 years ago

cc @jakirkham

bollwyvl commented 3 years ago

Alright, ducks in order based on above comments... will merge if it comes up green! Otherwise will be a few hours before I can monkey with it more...

jakirkham commented 3 years ago

Thanks Nick! 😄

bollwyvl commented 3 years ago

Thank you for catching my error :blush: and helping get the fix shipped :checkered_flag: ! Does anything i already ship with the wrong settings need to be re-released and/or marked broken?

jakirkham commented 3 years ago

Nope we should be good. There’s no error on your part. This is just a new setting we realized we needed to add.