Fix 0.4.3 build and install python package

conda-forge / gemmi-feedstock

A conda-smithy repository for gemmi.

BSD 3-Clause "New" or "Revised" License

1 stars 5 forks source link

Fix 0.4.3 build and install python package #30

Closed Anthchirp closed 3 years ago

Anthchirp commented 3 years ago

This

adds set -e in the bash builder to catch any catchable errors there
adds setuptools as build time dependency to fix the build and install the python package (fixes #20)
adds a test to ensure the python package is installed
adds a pip check test to ensure the resulting python environment is consistent
backports https://github.com/project-gemmi/gemmi/pull/57 to fix the inconsistent environment
add myself as maintainer

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

If python is a host requirement, it should be a run requirement.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Anthchirp commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

Anthchirp commented 3 years ago

@conda-forge-admin, please rerender

Anthchirp commented 3 years ago

Builds pass. I've put a summary of changes in the PR comment. This is ready for review/merging, @mcs07.

dagewa commented 3 years ago

Thanks, we're very keen to include gemmi in DIALS (https://github.com/dials/dials/issues/1266), which we've been looking at for 6 months. It would be great to remove any remaining obstacles.