Open regro-cf-autotick-bot opened 5 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin please rerender
it seems some tests are failing indication that this package isn't fully compatible with numpy 2. likely due to some stricter casting.
@hmaarrfk thanks for looking into it. It's only one test failing, because the test has too low numerical tolerance. It was fixed upstream: https://github.com/project-gemmi/gemmi/commit/8e92591abc28c6ccf005cfcb8d95a99e47571aef#diff-b94a30e235a15f119e6260734ea05ef5b630fcf1e6fc131eee3b78ed3fb4d302 (it's related to changes in fft implementation in numpy 2.0)
Is it OK to merge this PR despite the failing test?
No. The package won't upload.
Release a new version , patch, skip the test, or just wait
This PR has been triggered in an effort to update numpy2.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
Here are some more details about this specific migrator:
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/9283609549 - please use this URL for debugging.