search

conda-forge / geopandas-feedstock

A conda-smithy repository for geopandas.
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

Build development version #30

Closed ocefpaf closed 6 years ago

ocefpaf commented 6 years ago

@mrocklin can you take a quick look? I am using the tarball archive and not the actual branch, is that OK?

After merging this should be available for download with conda install -c conda-forge/dev geopandas

Closes #30

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mrocklin commented 6 years ago

cc @jorisvandenbossche

jorisvandenbossche commented 6 years ago

@ocefpaf Thanks a lot for this! Shall we target this PR to a 'dev' branch, so if we still do a 'normal' geopandas release we don't have to undo the changes?

ocefpaf commented 6 years ago

Shall we target this PR to a 'dev' branch, so if we still do a 'normal' geopandas release we don't have to undo the changes?

I created the dev branch and did not target it. My bad :flushed:

jorisvandenbossche commented 6 years ago

You can change that in a PR, no need to close.

ocetpaf: I know. I was going to do that for clarity. But this works too.

ocefpaf commented 6 years ago

Looks like Windows needs a fallback option to find geos.

jorisvandenbossche commented 6 years ago

Regarding windows, I think I experienced the same when trying to get it working on appveyor for tests: https://github.com/geopandas/geopandas/pull/570 (so but not sure how to solve it)

ocefpaf commented 6 years ago

Regarding windows, I think I experienced the same when trying to get it working on appveyor for tests: https://github.com/geopandas/geopandas/pull/570 (so but not sure how to solve it)

One way to do that is to let users specify it. I guess that a pattenr like this one or environmental variables would do. See my attempt in https://github.com/conda-forge/geopandas-feedstock/pull/30/commits/5c2e8e43b44c037e6ff860c08ff84205e35be5bc, if you are OK with that I can send a PR upstream.

jorisvandenbossche commented 6 years ago

Yes, such a patch to find the geos library would be welcome to send upstream

jorisvandenbossche commented 6 years ago

I merged the PR on geopandas, so the patch here can be removed?

ocefpaf commented 6 years ago

I merged the PR on geopandas, so the patch here can be removed?

Done. I guess this is OK to be merged now.

jorisvandenbossche commented 6 years ago

Great! Thanks a lot, this will make it much easier to test this out!

ocefpaf commented 6 years ago

Cool. They way it is set all you need to do is to bump the build number to get a new build with the latest checkout of the geopandas-cython branch. Note that to install this one needs to type:

conda install -c conda-forge/label/dev geopandas
jorisvandenbossche commented 6 years ago

Small correction, it is apparently conda-forge/label/dev. *

And that works!

joris@joris-XPS-13-9350:~/scipy$ conda create -n geopandas-test python=3 geopandas -c conda-forge
...
joris@joris-XPS-13-9350:~/scipy$ act geopandas-test
(geopandas-test) joris@joris-XPS-13-9350:~/scipy$ conda install -c conda-forge/label/dev geopandas
Fetching package metadata .................
Solving package specifications: .

Package plan for installation in environment /home/joris/miniconda3/envs/geopandas-test:

The following packages will be UPDATED:

    geopandas: 0.3.0-py36_0 conda-forge --> 1.0.0.dev-py36_0 conda-forge/label/dev

Proceed ([y]/n)? 

geopandas-1.0. 100% |################################################################################################################################################################################################################################| Time: 0:00:15 103.44 kB/s

(geopandas-test) joris@joris-XPS-13-9350:~/scipy$ python
Python 3.6.3 | packaged by conda-forge | (default, Nov  4 2017, 10:10:56) 
[GCC 4.8.2 20140120 (Red Hat 4.8.2-15)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import geopandas
>>> geopandas.__version__
'1.0.0.dev+101.g1c62492'
>>> df = geopandas.read_file(geopandas.datasets.get_path("naturalearth_cities"))
>>> df.head()
I am densified (5 elements)
           name                                     geometry
0  Vatican City  POINT (12.45338654497177 41.90328217996012)
1    San Marino    POINT (12.44177015780014 43.936095834768)
2         Vaduz  POINT (9.516669472907267 47.13372377429357)
3    Luxembourg  POINT (6.130002806227083 49.61166037912108)
4       Palikir  POINT (158.1499743237623 6.916643696007725)
>>> df.geometry._geometry_array
<geopandas.vectorized.GeometryArray object at 0x7fa3fd636940>

* using the wrong channel label is a bit confusing, as it doesn't give you an error that it doesn't exist, but just a strange warning and then continues while ignoring the channel:

(geopandas-test) joris@joris-XPS-13-9350:~/scipy$ conda install geopandas -c conda-forge/dev
Fetching package metadata ....
WARNING: The remote server could not find the noarch directory for the
requested channel with url: https://conda.anaconda.org/conda-forge/dev

It is possible you have given conda an invalid channel. Please double-check
your conda configuration using `conda config --show`.

If the requested url is in fact a valid conda channel, please request that the
channel administrator create `noarch/repodata.json` and associated
`noarch/repodata.json.bz2` files, even if `noarch/repodata.json` is empty.
$ mkdir noarch
$ echo '{}' > noarch/repodata.json
$ bzip2 -k noarch/repodata.json
.............
Solving package specifications: .

# All requested packages already installed.
# packages in environment at /home/joris/miniconda3/envs/geopandas-test:
#
geopandas                 0.3.0                    py36_0    conda-forge
ocefpaf commented 6 years ago

Yep. I forgot about the label, just fixed it above. Thanks!

PS: I agree that the wrong channel should result in an error.