conda-forge / geopandas-feedstock

A conda-smithy repository for geopandas.
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

test issue 31 #32

Closed ocefpaf closed 6 years ago

ocefpaf commented 6 years ago

@grahamanderson and @jorisvandenbossche this PR adds a test for issue #31. I cannot reproduce the issue on Windows and Linux. Let's keep an eye for Travis-CI to see if we can reproduce it on OS X.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 6 years ago

Travis-CI is passing on my instance, see https://travis-ci.org/ocefpaf/geopandas-feedstock/builds/313583866

@grahamanderson and @jorisvandenbossche, without access to a Mac it is hard for me to do anything else to debug this :unamused:

jorisvandenbossche commented 6 years ago

Thanks for checking here. I also don't have a Mac, so can't help out here ..

grahamanderson commented 6 years ago

@ocefpaf is there any way you can check (remotely) on my Mac? And, is it possible to include the Fiona devs—which is probably where the problem lies? Macs make up a sizable percentage of the data science’y folks. On my end, I’ll try a fresh install with pip today and report back. Thanks for giving us Mac users some love.

ocefpaf commented 6 years ago

@ocefpaf is there any way you can check (remotely) on my Mac?

My guess is that latest OS X system are shipping with a bundled geos. Not sure though, I am guessing that b/c people are successfully using our conda packages in older system. Can you try to confirm that?

And, is it possible to include the Fiona devs—which is probably where the problem lies?

In theory, a patch that I contributed, should fix that. So in a way the dev that should know about that me 😬

Macs make up a sizable percentage of the data science’y folks. On my end, I’ll try a fresh install with pip today and report back.

Indeed. We need a better way to build and test those packages for OS X.

BTW, can you try the packages in defaults, without conda-forge, just curious if they suffer from the same bug.