search

conda-forge / geopandas-feedstock

A conda-smithy repository for geopandas.
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

add license #43

Closed ocefpaf closed 6 years ago

ocefpaf commented 6 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jorisvandenbossche commented 6 years ago

Is it now best practice to include a copy of the license here instead of linking to license in package repo? (so if license is changed (eg year range), needs to update here as well)

ocefpaf commented 6 years ago

Is it now best practice to include a copy of the license here instead of linking to license in package repo? (so if license is changed (eg year range), needs to update here as well)

Actually the best practice is to have the license in the source tarball :smile:

I'm planning to send a PR upstream later to add it to the MANIFEST.in file to ensure it is there.

jorisvandenbossche commented 6 years ago

Ah, that's a good point .. :-)

ocefpaf commented 6 years ago

@msarahan this is a perfect example where the conda solver is hurting us. The environment is solvable using conda-forge only but b/c matplotlib is specified and conda tries to solve for the latest, and not the most stable, we get matplotlib with the latest pinning and a bunch of packages from defaults, including libgdal. This is a place where strict channel preference would really help!

jorisvandenbossche commented 6 years ago

@ocefpaf I suppose that comment was meant for another issue? sorry, I see that it is about the failing build

jorisvandenbossche commented 6 years ago

Amazing thing is that on Windows (on appveyor), mixing all those channels actually works .. (https://github.com/geopandas/geopandas/pull/796)

ocefpaf commented 6 years ago

Amazing thing is that on Windows (on appveyor), mixing all those channels actually works ..

Most of the time it does not. If you are hit by this please make some noise at

https://github.com/conda/conda/issues/7626

PS: restarting here to see if the new Qt in conda-forge helps clobbers the one from defaults.

ocefpaf commented 6 years ago

@conda-forge-admin, please rerender

ocefpaf commented 6 years ago

Re-rendering here is broken too, where is the Python matrix?

Argh. I made it noarch a long time ago. This channel mixing is driving me crazy!

ocefpaf commented 6 years ago

:tada: An all conda-forge hacky-solution works!!!

This is actually terrible b/c we should be able to play nice and have both channels in there but I'll keep using this hack until we have a better solution.