Update for 0.4.1 - Githubissues

conda-forge / geopandas-feedstock

A conda-smithy repository for geopandas.

BSD 3-Clause "New" or "Revised" License

16 stars 14 forks source link

Update for 0.4.1 #49

Closed jorisvandenbossche closed 5 years ago

jorisvandenbossche commented 5 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jorisvandenbossche commented 5 years ago

Ensured the license file is being packaged.

@ocefpaf did I understand your comment correctly in that the full line license_file: '{{ environ["RECIPE_DIR"] }}/LICENSE.txt' can be dropped (now the license file is in the tar.gz package), or do I still need to keep something like license_file: 'LICENSE.txt' ?

ocefpaf commented 5 years ago

You still have to keep license_file: 'LICENSE.txt'.

ocefpaf commented 5 years ago

@jorisvandenbossche you can also remove the LICENSE.txt from the feedstock.

gboeing commented 5 years ago

@jorisvandenbossche looks like the sha needs to be updated in meta.yml

jorisvandenbossche commented 5 years ago

@gboeing yep, was already doing that :-)

jorisvandenbossche commented 5 years ago

@ocefpaf So it is failing on the testing phase, because the created environment with fiona is broken ... :) (potentially similar problem as we have been talking about today). Is there a way to influence how the build process creates the environment to build / test geopandas? (eg use a strict channel config?)

ocefpaf commented 5 years ago

We should be discussed forcing strict in conda-forge builds but I don't think we'll do that soon. You just forced me to dig deep in find the culprit. (It may take a while though...)

jorisvandenbossche commented 5 years ago

@ocefpaf thanks a lot for figuring it out!

ocefpaf commented 5 years ago

@ocefpaf thanks a lot for figuring it out!

Thank you for your patience. Hopefully conda 4.7 will enforce strict channel by default and all our problems will go away. (Or we will just create new ones :stuck_out_tongue_winking_eye:)