search

conda-forge / geopandas-feedstock

A conda-smithy repository for geopandas.
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

pin pyproj #52

Closed ocefpaf closed 5 years ago

ocefpaf commented 5 years ago

Only util we build the rest of the stack with proj.4 6.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jorisvandenbossche commented 5 years ago

Dummy question here: shouldn't it "in principle" be gdal that is pinning this correctly? Since I suppose that it is for compatibility with gdal that proj < 6 is needed, for geopandas it doesn't matter much?

ocefpaf commented 5 years ago

Dummy question here: shouldn't it "in principle" be gdal that is pinning this correctly? Since I suppose that it is for compatibility with gdal that proj < 6 is needed, for geopandas it doesn't matter much?

That is not a dummy question and you are correct. However, old conda or odd setups with many channels many produce bad results. This "helps" conda do the right thing and does not hurt the geopandas package.

PS: I'm working on a migration to latest proj.4 soon. Just waiting on cartopy.

jorisvandenbossche commented 5 years ago

PS: I'm working on a migration to latest proj.4 soon. Just waiting on cartopy.

I need to start looking into using it more fully in geopandas as well (although it should be compatible already, going to add tests for that)

jorisvandenbossche commented 5 years ago

And thanks for the clarification!