conda-forge / geopandas-feedstock

A conda-smithy repository for geopandas.
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

Pyproj #75

Closed johnflavin closed 4 years ago

johnflavin commented 4 years ago

Checklist

This fixes an issue with incompatible packages being installed with the latest geopandas.

In version 0.7.0, geopandas began using the pyproj.CRS object. See the release blog post: https://jorisvandenbossche.github.io/blog/2020/02/11/geopandas-pyproj-crs/.

But pyproj.CRS was only added in pyproj version 2.0.0. See the pyproj changelog: https://pyproj4.github.io/pyproj/stable/history.html#id15.

In this change, I pin the geopandas recipe to require pyproj >=2.0.0.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

johnflavin commented 4 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

jorisvandenbossche commented 4 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

johnflavin commented 4 years ago

This doesn't seem to have worked. When I install an old version of pyproj and let conda figure out my version of geopandas, I still get a version of geopandas that will not work.

conda create -n gpd-pyproj 'python>=3.6' 'pyproj<2' geopandas
...
 geopandas          conda-forge/noarch::geopandas-0.7.0-py_0
...
  pyproj             conda-forge/osx-64::pyproj-1.9.6-py37h0b31af3_1002
...

Is there anything else we need to do to fix that? (I'm totally unaware of how conda forge recipes get built or distributed, so pardon me if this is a n00b question.)

jorisvandenbossche commented 4 years ago

Ah, that's because the package still exists (notice the last number in the geopandas package name, which is the build number, and that is 0 here. The package from after this PR will have build number 1). And so if you give this constraint of pyproj < 2, it will still find this older build of geopandas.

@ocefpaf if we want to fix this, I suppose this is a case of "fixing metadata" of existing packages (I don't know the exact terminology used, "hotfix" ?) But not sure if it is worth it here.

johnflavin commented 4 years ago

Is it possible to remove that build 0 of 0.7.0?

ocefpaf commented 4 years ago

It is and, and this case, it is the preferred method. Hotfixing or metadata correction are bad for reproducibility. Also, we don't really remove it, we moved to a"broken" label.

Doing it now.l, the changes should reflect on the CDN in about ~50 min.

jorisvandenbossche commented 4 years ago

Thanks @ocefpaf !

sravindr1 commented 4 years ago

Hi how to solve this issue , pyproj version 2.6.1.post1