Split in geopandas-base and geopandas outputs

conda-forge / geopandas-feedstock

A conda-smithy repository for geopandas.

BSD 3-Clause "New" or "Revised" License

16 stars 14 forks source link

Split in geopandas-base and geopandas outputs #90

Closed jorisvandenbossche closed 3 years ago

jorisvandenbossche commented 3 years ago

This creates two outputs: geopandas-base with the minimal dependencies, and geopandas which additionally depends on rtree, fiona and matplotlib-base (we previously did not include matplotlib in the dependencies, but with the split and the availability of matplotlib-base, I think we can add it back)

xref https://github.com/geopandas/geopandas/issues/1261, https://github.com/geopandas/geopandas/issues/1313

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The outputs section contained an unexpected subsection name. noarch is not a valid subsection name.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jorisvandenbossche commented 3 years ago

@conda-forge-admin, please rerender

jorisvandenbossche commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

jorisvandenbossche commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

jorisvandenbossche commented 3 years ago

Some issues:

It seems to have added builds for windows/linux/osx, so the noarch no longer works?
The build error is 'PYTHON' is undefined. Is that not supported in a nested build script (nested in outputs:)?

jorisvandenbossche commented 3 years ago

@conda-forge-admin, please add noarch: python

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

martinfleis commented 3 years ago

What about mapclassify? I'd vote for adding it alongside matplotlib, even though it comes with some other dependencies.

With upcoming explore, I assume we will want to have it supported out of the box with conda install geopandas and that depends on mapclassify even for non-scheme choropleths, so we will be likely adding it soon anyway.

jorisvandenbossche commented 3 years ago

@conda-forge-admin, please rerender

jorisvandenbossche commented 3 years ago

@martinfleis hmm, yes mapclassify would probably be good to add as well, but that indeed brings in scipy and scikit-learn ..

martinfleis commented 3 years ago

but that indeed brings in scipy and scikit-learn

You can always go with geopandas-base if you don't want them. Most people won't mind and those who do have another option.

jorisvandenbossche commented 3 years ago

OK, let's see how this goes ;)