Use modern features of Windows CMake build

conda-forge / geos-feedstock

A conda-smithy repository for geos.

BSD 3-Clause "New" or "Revised" License

3 stars 16 forks source link

Use modern features of Windows CMake build #55

Closed mwtoews closed 3 years ago

mwtoews commented 3 years ago

With the CMake build setup for Windows, there are a few stale lines that should be modernized:

File geos_svn_revision.h no longer used
GEOS_BUILD_STATIC was removed from a previous GEOS release. Use BUILD_SHARED_LIBS=ON.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

mwtoews commented 3 years ago

Another addition to this PR is to use the Ninja build system for Windows build to speed it up. Using the "NMake Makefiles" generator took nearly 23 minutes.

ocefpaf commented 3 years ago

This is definitely a welcomed change but I'm not qualified to review it. @gillins can you merge this if you are OK with it?

gillins commented 3 years ago

Thanks @mwtoews