Add msgfmt test - Githubissues

conda-forge / gettext-feedstock

A conda-smithy repository for gettext.

BSD 3-Clause "New" or "Revised" License

0 stars 20 forks source link

Add msgfmt test #13

Closed tschoonj closed 4 years ago

tschoonj commented 4 years ago

This PR serves to demonstrate a problem that was somehow introduced in #12, resulting in msgfmt crashing on Windows when used as part of a conda build (it seems to works fine from a regular environment). The problem was first observed in https://github.com/conda-forge/glib-networking-feedstock/pull/3.

@isuruf @ocefpaf @xhochy

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

tschoonj commented 4 years ago

This now also occurring in https://github.com/conda-forge/atk-feedstock/pull/17 and will probably pop up in all builds that use gettext on Windows.

isuruf commented 4 years ago

There's https://github.com/conda-forge/admin-requests where we can mark a build as broken

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [33, 34, 35, 36, 37, 38].
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [36, 37, 38, 39, 40, 41].
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

tschoonj commented 4 years ago

Looks like I fixed things while keeping support for OSX ARM.

One remaining thing to fix is the license: it looks to me that there parts LGPL-2 and other bits are GPL-3... how does one write that down?

isuruf commented 4 years ago

LGPL-2.0-or-later AND GPL-3.0-or-later (exact version might be different and -or-later might need to be changed -only)

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

tschoonj commented 4 years ago

Thanks for that. Fixes pushed. Feel free to merge in once everything goes green.

isuruf commented 4 years ago

@conda-forge-admin, rerender.

pkgw commented 4 years ago

@tschoonj Is it clear what the actual problem is/was here? From the final diffs, it looks like the main change is to lock to VS 2015?

tschoonj commented 4 years ago

Yep that appears to be the culprit. No idea why though.

tschoonj commented 4 years ago

Thanks @pkgw and @isuruf!