search

conda-forge / gettext-feedstock

A conda-smithy repository for gettext.
BSD 3-Clause "New" or "Revised" License
0 stars 20 forks source link

Update to 0.21.1 #23

Closed pkgw closed 2 years ago

pkgw commented 2 years ago

Here's an extension of #22 where I want to see what happens if I bump to the latest upstream, 0.21. Updating Windows patches was annoying and there were some changes relating to stuff that needed to be patched before, so ... we'll see.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pkgw commented 2 years ago

Currently stuck on some terrible autotools issue where _AM_PROG_CC_C_O is not being invoked although it should be automatically through invocations of AC_PROG_CC in the configure.ac files. Sudden wave of gratitude that I don't have to regularly use the autotools anymore!

pkgw commented 2 years ago

Figured out what was going on and got some tips from the maintainer about how to fix things. I was also told that 0.21 has an important bug in Windows that will be solved in an upcoming 0.21.1 release, so this should not be merged yet.

edit: listing to check is: https://ftp.gnu.org/gnu/gettext/?C=M;O=D

pkgw commented 2 years ago

0.21.1 has been released. I've updated and changed the MSVC build tactics as recommended. Let's see how we do!

pkgw commented 2 years ago

@conda-forge/gettext Well, it finally builds ...

ocefpaf commented 2 years ago

@pkgw do you want to add yourself as a maintainer here before we merge this one?

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!