Closed xhochy closed 7 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
This has been deprecated in favor of the top-level `test` field.
It is now mapped to `test: native_and_emulated`.
Failed validating 'deprecated' in schema['properties']['test_on_native_only']:
{'anyOf': [{'type': 'boolean'}, {'type': 'null'}],
'default': False,
'deprecated': True,
'description': 'This was used for disabling testing for '
'cross-compiling.\n'
'\n'
'```warning\n'
'This has been deprecated in favor of the top-level '
'`test` field.\n'
'It is now mapped to `test: native_and_emulated`.\n'
'```',
'title': 'Test On Native Only'}
On instance['test_on_native_only']:
True
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
meta.yaml
, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint .
from the recipe directory. Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge/gettext @conda-forge/core This is ready for review. It is a major rework of this package and thus I would appreciate a good review. I have also set the target_channel to gettext_dev
to build glib and similar libs first before pushing it to main as there have been problems before and I want to be extra sure to not break conda-forge with this.
@ocefpaf As a feedstock maintainer here, is it OK to proceed? This PR also adds me as a maintainer.
Thanks @xhochy and @pkgw! BTW, don't wait for me to merge things like this. I will be "away" for a few weeks.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)