Build 8.10.4 from source

conda-forge / ghc-feedstock

A conda-smithy repository for ghc.

BSD 3-Clause "New" or "Revised" License

2 stars 14 forks source link

Build 8.10.4 from source #16

Closed xhochy closed 3 years ago

xhochy commented 3 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xhochy commented 3 years ago

Adopted @isuruf's PR #14 a bit and also got a working osx-64 build. Sadly CI fails due to out-of-memory issues on prefix replacement of one of the larger files. I'm trying to debug that locally but there it succeeds as I have more RAM. If anyone has an idea how to get CI green with the limited RAM, I'd be happy for that.

xhochy commented 3 years ago

The timeout on osx-64 depends on getting https://github.com/lief-project/LIEF/pull/579 (or a similar approach) merged.

xhochy commented 3 years ago

@conda-forge/ghc This is ready for review. I would handle ppc64le separately as the executable size seems to be more than three times than that on others and thus very hard to fit into CI.

And I would like to make progress to get an osx-arm64 build with the latest 9.2.1rc 😉

step21 commented 3 years ago

Thanks a lot for this work. Previously I spent already way too much time on this. For learning, what was the most important that was missing from the previous PRs? Really weird about the ppc64le, but that one is also the hardest to test both locally and on CI (unless someone has a local machine idling around)

xhochy commented 3 years ago

Thanks a lot for this work. Previously I spent already way too much time on this. For learning, what was the most important that was missing from the previous PRs?

Not sure what that could be, all tiny additions. The only major thing was https://github.com/lief-project/LIEF/pull/579 to get the osx-* postprocessing fast enough.

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!