Fixes #82 - Githubissues

conda-forge / git-feedstock

A conda-smithy repository for git.

BSD 3-Clause "New" or "Revised" License

1 stars 32 forks source link

Closed j-4 closed 4 years ago

j-4 commented 4 years ago

Fixes #82 by checking if the REQUESTS_CA_BUNDLE env variable is set, otherwise use conda certificates.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

j-4 commented 4 years ago

@conda-forge-admin, please rerender

scopatz commented 4 years ago

Seems reasonable to me

scopatz commented 4 years ago

Thanks @j-4!

domste commented 4 years ago

I have tried it and the changes did not fix the problem because the variable is read in the build step, but it needs to be set after "installation".

So the settings should be set post-linkage via a post-linkage script such that git config is written during the installation process.

I am preparing a PR.