search

conda-forge / glpk-feedstock

A conda-smithy repository for glpk.
BSD 3-Clause "New" or "Revised" License
2 stars 12 forks source link

WIP: MNT: Re-render the feedstock #7

Closed conda-forge-admin closed 8 years ago

conda-forge-admin commented 8 years ago

Hi! This is the friendly conda-forge-admin automated user.

I've re-rendered this feedstock with the latest version of conda-smithy (0.10.3) and noticed some changes. If the changes look good, then please go ahead and merge this PR. If you have any questions about the changes though, please feel free to ping the 'conda-forge/core' team (using the @ notation in a comment).

Remember, for any changes to the recipe you would normally need to increment the version or the build number of the package. Since this is an infrastructural change, we don't actually need/want a new version to be uploaded to anaconda.org/conda-forge, so the version and build/number are left unchanged and the CI has been skipped.

Thanks!

conda-forge-linter commented 8 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

jakirkham commented 8 years ago

Linter error here is the same as in this issue ( https://github.com/conda-forge/glpk-feedstock/issues/6 ). Will ignore for now to get this updated.

jakirkham commented 8 years ago

This cannot be merged yet. I have pointed out the problem above. I doubt this is related to the selector, but if it is we need to fix that first.

jjhelmus commented 8 years ago

Agreed, this should not be merged. The Python selectors are needed to produce the three vc variants of the library. Is the lint the reason why smithy is trying to remove the selectors?

jjhelmus commented 8 years ago

Nope, even after correcting the lint, conda smithy rerender still removes the Python selectors.

jakirkham commented 8 years ago

After looking at the recipe closer, I believe the problem is we are not including python as a build dependency on Windows. Please see this line.

jjhelmus commented 8 years ago

I seem to recall there was some reason for not including python as a build dependency on Windows when the recipe was in staged-recipes but I can't recall the reason now. Let me try adding that to the recipe and see what happens.

jjhelmus commented 8 years ago

Not seeing a problem with including Python as a build dependency on Windows (PR #9) so might as well include it.

pelson commented 8 years ago

Yay! This is the usecase I have wanted to solve for some time now. Basically, I'm inclined to add vc knowledge to the build matrix, make vc a build dependency (on windows), and remove the features noise that comes with all of these compiled C packages on Windows.

I'd merge #9, close this, then we can see how the new scheme would look in a few days.