search

conda-forge / glpk-feedstock

A conda-smithy repository for glpk.
BSD 3-Clause "New" or "Revised" License
2 stars 12 forks source link

Fix-up selectors #8

Closed jakirkham closed 8 years ago

jakirkham commented 8 years ago

Fixes https://github.com/conda-forge/glpk-feedstock/issues/6

Fix-up selectors to match the expected style. Namely, there are comments now with proper spacing.

conda-forge-linter commented 8 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 8 years ago

Seems to be a test failure. No reason this change would cause it. Thoughts on this @jjhelmus or @aebrahim? 

======================================================================

ERROR: spam (unittest.loader._FailedTest)

----------------------------------------------------------------------

ImportError: Failed to import test module: spam

Traceback (most recent call last):

  File "/Users/travis/miniconda3/envs/_test/lib/python3.5/unittest/loader.py", line 153, in loadTestsFromName

    module = __import__(module_name)

ImportError: No module named 'spam'

----------------------------------------------------------------------
jjhelmus commented 8 years ago

@jakirkham After re-rendering the recipe I'm not seeing the test failure #9. May caused by something coming from brew?

jakirkham commented 8 years ago

Let's go with ( https://github.com/conda-forge/glpk-feedstock/pull/9 ).