search

conda-forge / glpk-feedstock

A conda-smithy repository for glpk.
BSD 3-Clause "New" or "Revised" License
2 stars 12 forks source link

Remove lint and re-render recipe #9

Closed jjhelmus closed 8 years ago

jjhelmus commented 8 years ago

closes #6

conda-forge-linter commented 8 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jjhelmus commented 8 years ago

@jakirkham This seems to fix the issue you were seeing in #8, do you want to include those changes in your PR or work from this one.

pelson commented 8 years ago

Excellent. LGTM 👍

jakirkham commented 8 years ago

Maybe we can @aebrahim if he remembers why python was missing from the build dependencies here.

jjhelmus commented 8 years ago

The feedstock was generated by conda-forge/staged-recipes#141 during which the Python dependency was moved from build to run in commit 73bc95. Before that move the build was failing in Python 3.5 but worked with the change. Looking at this now it seems as if the important part was to have python as a run dependency, not necessarily removing it as a build dependency.

For the build itself python is not required but conda smithy requires it to render the matrix which is required in order the build for all three VC versions.

aebrahim commented 8 years ago

I think it was in there originally. Not sure why it was removed (I don't think I even removed it). On May 16, 2016 07:38, "Jonathan J. Helmus" notifications@github.com wrote:

The feedstock was generated by conda-forge/staged-recipes#141 https://github.com/conda-forge/staged-recipes/pull/141 during which the Python dependency was moved from build to run in commit 73bc95 https://github.com/conda-forge/staged-recipes/pull/141/commits/73bc95b628fb471e3da0e4d1b43c8a338f0c193a. Before that move the build was failing in Python 3.5 https://ci.appveyor.com/project/conda-forge/staged-recipes/build/1.0.222 but worked with the change https://ci.appveyor.com/project/conda-forge/staged-recipes/build/1.0.232. Looking at this now it seems as if the important part was to have python as a run dependency, not necessarily removing it as a build dependency.

For the build itself python is not required but conda smithy requires it to render the matrix which is required in order the build for all three VC versions.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/conda-forge/glpk-feedstock/pull/9#issuecomment-219441723

jakirkham commented 8 years ago

Sounds like this sounds good to everyone. Going to go ahead and merge.