search

conda-forge / gmprocess-feedstock

A conda-smithy repository for gmprocess.
BSD 3-Clause "New" or "Revised" License
1 stars 7 forks source link

bump #52

Closed ocefpaf closed 3 years ago

ocefpaf commented 3 years ago

re-render to activate Windows.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

emthompson-usgs commented 3 years ago

Looks like we both did essentially the same thing simultaneously (see #51), only difference is I also created a new release to get the latest updates of the source code.

ocefpaf commented 3 years ago

Looks like we both did essentially the same thing simultaneously (see #51), only difference is I also created a new release to get the latest updates of the source code.

Your PR is great but it looks like the new tag does not include enough information for the version. Do you know if the M_PI was fixed? If not we may need to upstream my patch here.

emthompson-usgs commented 3 years ago

I did not fix M_PI

ocefpaf commented 3 years ago

@emthompson-usgs good news are that the patch works and this builds on Windows. I have a few experiments I want to run before upstreaming them.

The bad news is that our workaround in openquake did not work here :-(

I'll remove the bad openquake packages and rebuild with a proper patch to the manifest file.

emthompson-usgs commented 3 years ago

Wow, that's great that the C code looks to be compiling. Amazing!

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

emthompson-usgs commented 3 years ago

@ocefpaf I meant to say that we are now able to build the upstream package in Windows on PRs with Azure CI. I thought it would make sense to merge that update with the changes you made here. Also, there was a typo in my commit above (I meant "lint" not "link").

emthompson-usgs commented 3 years ago

The problem is pretty clearly with how I configured setuptools-scm for reporting the code version, but I'm not seeing where the problem is, and I'm not able to reproduce the error locally.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

emthompson-usgs commented 3 years ago

Building locally with pip install -e only worked if I pinned pip to 18.0 when creating the conda virtual environment. I can't explain why. The different version of pip is the only significant difference I can find between the package versions in the conda builds and what I have in the venv that successfully built this locally so I thought it was worth a try. But my attempt at pinning doesn't seem to be taking because the logs show that conda is still using pip 20.3.3.

ocefpaf commented 3 years ago

Building locally with pip install -e only worked if I pinned pip to 18.0 when creating the conda virtual environment. I can't explain why. The different version of pip is the only significant difference I can find between the package versions in the conda builds and what I have in the venv that successfully built this locally so I thought it was worth a try. But my attempt at pinning doesn't seem to be taking because the logs show that conda is still using pip 20.3.3.

Let me take a look upstream, something is amiss here since modern pip should be OK with setuptools_scm.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 3 years ago

@emthompson-usgs let's work on the new version now! It took a while and some tweaks to openquake.engine but this is passing!

emthompson-usgs commented 3 years ago

Okay, amazing! I'll go re-open the PR for the the most recent version.

emthompson-usgs commented 3 years ago

I believe that I applied the patch in this PR upstream so future versions won't need it.