search

conda-forge / google-cloud-cpp-feedstock

A conda-smithy repository for google-cloud-cpp.
BSD 3-Clause "New" or "Revised" License
2 stars 10 forks source link

Update google-cloud-cpp to v2.11.0 #139

Closed dbolduc closed 1 year ago

dbolduc commented 1 year ago

I could not figure out how to add commits onto #138, so here is a new PR.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 1 year ago

I could not figure out how to add commits onto #138, so here is a new PR.

That's because you're not a maintainer on this feedstock... yet? ;-) I see you're an upstream maintainer, so I'd be happy to have you on board!

(to do so, add your GH handle in the appropriate section at the end of the meta.yaml)

h-vetinari commented 1 year ago

Also, note that this PR doesn't automatically get the newest protobuf version pulled in (that takes extra steps which are currently waiting in a separate PR). So IIUC, we shouldn't yet remove the patch that disables some features, because this build is still against protobuf 3.21. Some short discussion on this with Carlos is in #136

dbolduc commented 1 year ago

add your GH handle in the appropriate section

Done.

this PR doesn't automatically get the newest protobuf version pulled in

Ah, ok. I now see how the "Rebuild for protobuf423" PRs update the protobuf version in the .ci_support/*.yaml files.

I rebased the patch. (Maybe I could have included the commits from #137 in this PR, but oh well).

h-vetinari commented 1 year ago

Ah, ok. I now see how the "Rebuild for protobuf423" PRs update the protobuf version in the .ci_support/*.yaml files.

We don't have to do that manually, that's done by the bot (which can be invoked like [at]conda-forge-admin, please rerender, or if you have conda smithy installed locally, as conda smithy rerender in the feedstock base folder).

If you want we can already pick the relevant commit (https://github.com/conda-forge/google-cloud-cpp-feedstock/pull/137/commits/6da07f47b93a60bec4379fc731c6d11bd8faadfd) into this PR and then rerender. Or we do it in separate PRs (which is perhaps cleaner), no strong feelings.

Happy to have you on board!