Fix activate.sh - Githubissues

conda-forge / gpaw-feedstock

A conda-smithy repository for gpaw.

BSD 3-Clause "New" or "Revised" License

7 stars 7 forks source link

Fix activate.sh #21

Closed jan-janssen closed 3 years ago

jan-janssen commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

jan-janssen commented 3 years ago

@conda-forge-admin, please rerender

marcindulak commented 3 years ago

Just a comment - would it be possible to add a rudimentary test of gpaw functionality after the build is finished in ci?

gpaw test

https://wiki.fysik.dtu.dk/gpaw/install.html#run-a-simple-test-calculation

It would be nice if ci can confirm the basic functionality works.

thomasaarholt commented 3 years ago

Brilliant, thanks Jan.

jan-janssen commented 3 years ago

@thomasaarholt Sure, I am always happy to help. By the way you can find a list of all the conda package I maintain under https://github.com/jan-janssen/conda-forge-contribution just in case you have some more suggestions.