conda-forge / graphviz-feedstock

A conda-smithy repository for graphviz.
BSD 3-Clause "New" or "Revised" License
5 stars 29 forks source link

Build with GTK3 and cleanup recipe #130

Closed conda-forge-admin closed 2 weeks ago

conda-forge-admin commented 11 months ago

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #129.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 11 months ago

@conda-forge-admin please rerender

github-actions[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/graphviz-feedstock/actions/runs/6910944172.

hmaarrfk commented 11 months ago

this kinda works, we need to change one gdk import

hmaarrfk commented 11 months ago

This doesn't seem really sanctioned by upstream: https://gitlab.com/graphviz/graphviz/-/issues/1848

hmaarrfk commented 11 months ago

the reason i was interested in this is that I thought I was getting some gtk squashing warnings....

hmaarrfk commented 10 months ago

Does anybody know how to test a GTK2/3 feature???? I'm somewhat tempted to test this since gtk2 clobbers with gtk3 https://github.com/conda-forge/gtk2-feedstock/issues/24

ocefpaf commented 2 weeks ago

Does anybody know how to test a GTK2/3 feature???? I'm somewhat tempted to test this since gtk2 clobbers with gtk3 conda-forge/gtk2-feedstock#24

Is this still an issue? Can we close this one? Sorry I'm can't help much here.

hmaarrfk commented 2 weeks ago

Well I think we should build with gtk3.

Upstream thinks there is more to do than my tiny patch. But didn’t offer much guidance and seems to think their gym tool doesn’t get much usage.

hmaarrfk commented 2 weeks ago

Oh this was pulled into 12!!!!!

https://gitlab.com/graphviz/graphviz/-/commit/70632d8f43f5b79c747b10f09a1689023943465b