conda-forge / graphviz-feedstock

A conda-smithy repository for graphviz.
BSD 3-Clause "New" or "Revised" License
5 stars 29 forks source link

TravisCI builds are annoying #77

Closed nehaljwani closed 2 years ago

nehaljwani commented 2 years ago

Many instances suffer from this bug: https://travis-ci.community/t/procfs-provides-paths-outside-of-container/9525

The bug breaks this code in graphviz (lib/gvc/gvconfig.c):

324             FILE* f = fopen ("/proc/self/maps", "r");
325             char* path;
326             if (f) {
327                 while (!feof (f)) {
328                     if (!fgets (line, sizeof (line), f))
329                         continue;
330                     if (!strstr (line, " r-xp "))
331                         continue;
332                     path = strchr (line, '/');
333                     if (!path)
334                         continue;
335                     tmp = strstr (path, "/libgvc.");
336                     if (tmp) {
337                         *tmp = 0;
338                         /* Check for real /lib dir. Don't accept pre-install /.libs */
339                         if (strcmp(strrchr(path,'/'), "/.libs") == 0)
340                             continue;
341                         memmove(line, path, strlen(path) + 1);  /* use line buffer for result */
342                         strcat(line, "/graphviz");  /* plugins are in "graphviz" subdirectory */
343                         libdir = line;
344                         break;
345                     }
346                 }
347                 fclose (f);
348             }

Same problem applies to pygraphviz too. The only solution is to keep re-triggering until a good node shows up.

nehaljwani commented 2 years ago

@ocefpaf Is it possible to get some official response from TravisCI on this?

ocefpaf commented 2 years ago

@ocefpaf Is it possible to get some official response from TravisCI on this?

Folks are looking into it. I'm kind of merging without it for now. There is really much we can do :-/

For more info check: https://github.com/conda-forge/conda-forge.github.io/issues/1521

nehaljwani commented 2 years ago

This issue is different than the download-from-GH one. It has been this way for a long time.

nehaljwani commented 2 years ago

This is no longer an issue now. Resolved via https://github.com/conda-forge/graphviz-feedstock/pull/81