Closed regro-cf-autotick-bot closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
While we are at it, can we add -DGMX_INSTALL_LEGACY_API=ON
to the cmake options for https://github.com/conda-forge/votca-feedstock/pull/9 (and https://github.com/votca/votca/issues/1002).
While we are at it, can we add
-DGMX_INSTALL_LEGACY_API=ON
to the cmake options for conda-forge/votca-feedstock#9 (and votca/votca#1002).
I'll have a look at the build scripts - I think we could probably add this for you.
While we are at it, can we add
-DGMX_INSTALL_LEGACY_API=ON
to the cmake options for conda-forge/votca-feedstock#9 (and votca/votca#1002).I'll have a look at the build scripts - I think we could probably add this for you.
Along those lines, is there a facility for identifying and fixing the recorded toolchain details? Historically, the conda builds of gromacs report invalid tool chains with gmx --version
and in the installed ...hints.cmake
file, so client software (such as by using FindGROMACS.cmake
) always gets reported errors of some sort or another.
(@junghans how does the conda-forge votca handle this? Does it just use an arbitrary compiler and not run the check_compiler()
function?)
(@junghans how does the conda-forge votca handle this? Does it just use an arbitrary compiler and not run the
check_compiler()
function?)
VOTCA's CMake runs check_cxx_compiler_flag()
, but we haven't seen any problems with gromacs yet.
(@junghans how does the conda-forge votca handle this? Does it just use an arbitrary compiler and not run the
check_compiler()
function?)VOTCA's CMake runs
check_cxx_compiler_flag()
, but we haven't seen any problems with gromacs yet.
Sorry. I was vague and inaccurate. Historically, GROMACS recommended that client software run gromacs_check_compiler(CXX)
as in https://gitlab.com/gromacs/gromacs/-/blob/main/share/template/CMakeLists.txt.template, but this generally hasn't worked when gromacs was installed with conda (because the embedded toolchain paths are as seen during the isolated conda-build).
I'm assuming VOTCA doesn't use the gromacs_check_compiler()
, then. Do you do anything else to ensure a compatible toolchain? Maybe it just tend to work fine with default conda build tools?
I'm assuming VOTCA doesn't use the
gromacs_check_compiler()
, then. Do you do anything else to ensure a compatible toolchain? Maybe it just tend to work fine with default conda build tools?
Correct, we only run find_package(GROMACS)
and we just hope conda/rpm/the packager is using the same build tools.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot. :( Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2978919736, please use this URL for debugging.