Do not use RDTSCP - Githubissues

conda-forge / gromacs-feedstock

A conda-smithy repository for gromacs.

BSD 3-Clause "New" or "Revised" License

0 stars 9 forks source link

Do not use RDTSCP #24

Closed mattwthompson closed 12 months ago

mattwthompson commented 1 year ago

Possible simple solution to #23

I can't think of a straightforward way of testing the original issue here as it requires running something in containers I'm not sure we have access to

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mattwthompson commented 1 year ago

@conda-forge-admin, please rerender

mabraham commented 1 year ago

This potentially trades a tiny bit of performance in mdrun for a bit of extra portability (either to very old x86 hardware or to virtual machine contexts in which the manager makes e.g. AVX* available but not RDTCSP; I have seen the latter elsewhere). The portability is relevant to running tests in CI using the GROMACS binaries built by this project, as people are often using the cheapest (oldest) resources available. The performance of mdrun is not of high importance to users of GROMACS who've chosen the convenience of a conda build. So overall it is a good improvement.

conda-forge-webservices[bot] commented 12 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-webservices[bot] commented 12 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mattwthompson commented 12 months ago

Thank you!