conda-forge / gromacs-feedstock

A conda-smithy repository for gromacs.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

ARM OSX Migrator #34

Closed xiki-tempula closed 10 months ago

xiki-tempula commented 10 months ago

Checklist

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

douglowe commented 10 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gromacs-feedstock/actions/runs/7008191760.

douglowe commented 10 months ago

Our build problem is:

Traceback (most recent call last):
  File "/opt/conda/bin/conda-mambabuild", line 10, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 256, in main
    call_conda_build(action, config)
  File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 228, in call_conda_build
    result = api.build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/api.py", line 253, in build
    return build_tree(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 3804, in build_tree
    packages_from_this = build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 2673, in build
    utils.check_call_env(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/utils.py", line 445, in check_call_env
    return _func_defaulting_env_to_os_environ("call", *popenargs, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/utils.py", line 421, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['/bin/bash', '-o', 'errexit', '/home/conda/feedstock_root/build_artifacts/gromacs_1701103828945/work/conda_build.sh']' returned non-zero exit status 2.
douglowe commented 10 months ago

But, on the upside - it looks like the ARM64 openmpi builds are no longer running.

douglowe commented 10 months ago

This is all looking good to me too.

However, please can you bump the build number (meta.yaml, line 6) before this is merged?

xiki-tempula commented 10 months ago

Sorry for the confusion. We had this pipeline problem so I just revert to the initial commit where the pipeline passes and then go one by one trying to sort things out.

xiki-tempula commented 10 months ago

Ok, I guess the reason that build.sh is missing an fi weird that it passed before.

xiki-tempula commented 10 months ago

@conda-forge-admin, please rerender

xiki-tempula commented 10 months ago

Ok, I have finally found out why the pipeline fails. I kind of based my branch on conda-forge/gromacs-feedstock:bot-pr_arm_osx_h742397 and assume that it is the same branch as the one in https://github.com/conda-forge/gromacs-feedstock/pull/30, but they are not the same branch and missed two crucial commits which is why my pipeline is always failing.

xiki-tempula commented 10 months ago

@douglowe I think it is working now. Do you mind merge this PR, please? Thank you.

douglowe commented 10 months ago

Great - it looks good to me :) I'll merge it now.