Fix the osx-arm64 build

conda-forge / gromacs-feedstock

A conda-smithy repository for gromacs.

BSD 3-Clause "New" or "Revised" License

0 stars 9 forks source link

Fix the osx-arm64 build #45

Closed xiki-tempula closed 5 months ago

xiki-tempula commented 5 months ago

The arm64 mac has $(uname -m) as arm64 not arm Fix https://github.com/conda-forge/gromacs-feedstock/issues/44

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. For further details, please see https://github.com/conda-forge/conda-forge.github.io/issues/2102.

xiki-tempula commented 5 months ago

I did this change to my local M1 mac and it works now.

xiki-tempula commented 5 months ago

@douglowe @mabraham Shall we consider merging this ASAP? As without this patch none of the arm64 build would work. We might also want to deprecate all the existing arm64 builds as they are all broken.

mabraham commented 5 months ago

I tried to make the match more flexible. If someone can do a local test on Mac ARM, then I think we shoudl merge asap!