conda-forge / gromacs-feedstock

A conda-smithy repository for gromacs.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

Escape command substitutions in gromacs_activate.csh #50

Closed martin-g closed 5 months ago

martin-g commented 5 months ago

Until now the command substitutions were evaluated eagerly, i.e. at build time. Now they will be evaluated at run/execution time.

To confirm the problem in the current version of the script:

i.e. the environment variable uname is already set to x86_64 because this is the CPU architecture at Azure CI. This script is unusable at Mac OSX ARM64.

Checklist

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

martin-g commented 5 months ago

@conda-forge-admin, please rerender

xiki-tempula commented 4 months ago

It seems that this PR has removed all the CUDA builds?

mabraham commented 4 months ago

Not by design! @martin-g thoughts?

martin-g commented 4 months ago

The re-rendering decided that those files are no more needed. @xhochy Any hints why the renderer does this ?

martin-g commented 4 months ago

According to https://conda-forge.org/docs/maintainer/knowledge_base/#cuda-builds all that is needed is having - {{ compiler('cuda') }} in meta.yaml, and it is (still) there - https://github.com/conda-forge/gromacs-feedstock/blob/218742281fb62fe72e55c835e9204f5b73370a4d/recipe/meta.yaml#L33

martin-g commented 4 months ago

@jakirkham I believe you are the CUDA expert at Conda-Forge. Do you know why the re-rendering removed the CUDA support for gromacs ? At https://github.com/conda-forge/gromacs-feedstock/pull/54 I am trying different things but I cannot make it bring back nvcc compiler in the generated settings.

martin-g commented 4 months ago

@conda-forge/core Could someone help us here with a CUDA compiler settings change after re-rendering ? Thanks!