search

conda-forge / grpcio-health-checking-feedstock

A conda-smithy repository for grpcio-health-checking.
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

AttributeError: module 'google.protobuf.descriptor' has no attribute '_internal_create_key' #1

Closed s22chan closed 4 years ago

s22chan commented 4 years ago

These python bindings are generated with the latest version of the protoc, but this requires at least protobuf>=3.12.

https://github.com/protocolbuffers/protobuf/commit/b99994d994e399174fe688a5efbcb6d91f36952a

The constraints need to be updated to avoid breaking older protobuf environments (either by patching the existing package or marking that one bad and doing a rebuild)

bollwyvl commented 4 years ago

Thanks, for the report, I hadn't used this in anger yet, nor did i see a simple way to test it during the build.

I'm very hesitant to patch things related to grpc/protobuf, as they get exceedingly hard to maintain/debug when they break. I'll start researching, but if you know the exact pin needed, it would save some time.

bollwyvl commented 4 years ago

Also, if you have any insight on how to test this constraint simply to avoid these problems in the future, that would be extremely helpful... a quick look didn't show anything helpful in the upstream tarball...

bollwyvl commented 4 years ago

Think this is sorted by the two above linked PRs: please reopen if there are any other concerns... or if you have any suggestions on how to simplify the testing while making sure things keep working!

s22chan commented 4 years ago

Thanks for the super comprehensive changes (good idea with the test imports). I don't think upstream will be super helpful as the google stuff is somewhat notorious, since internally they use bazel to build the universe.