conda-forge / gsl-feedstock

A conda-smithy repository for gsl.
BSD 3-Clause "New" or "Revised" License
6 stars 18 forks source link

Use recommended GSL linkage for openblas. #38

Closed jeromekelleher closed 5 years ago

jeromekelleher commented 5 years ago

Checklist

Following up on #37, try to resolve linkage errors in #34 by using the recommended recipe for linking GSL against alternative BLAS implementations.

@duncanmmacleod: I just thought I'd try this out and see what breaks.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jeromekelleher commented 5 years ago

Cool, looks like this builds! @duncanmmacleod, would you mind trying this out on your local build to see if it fixes your linking problems?

@isuruf, what do you think, are you OK with changing the linking like this?

If we agree this is a good way to go I'll render the feedstock later before merging. Just wanted to keep the diff minimal for review purposes for the moment.

duncanmmacleod commented 5 years ago

@jeromekelleher, this failed to link for me, much earlier than it used to:

dyld: Library not loaded: @rpath/libgsl.23.dylib
  Referenced from: /Users/duncan/opt/miniconda3/conda-bld/lal_1545399317005/work/./conftest
  Reason: image not found
jeromekelleher commented 5 years ago

@jeromekelleher, this failed to link for me, much earlier than it used to:

Ah OK, looks like there's some mac stuff going on. It was worth a try anyway. Let's see what the others think --- probably your PR is the way to go.

jakirkham commented 5 years ago

Looks like PR ( https://github.com/conda-forge/gsl-feedstock/pull/37 ) was merged. Is this still needed?

jeromekelleher commented 5 years ago

Closing this as #37 fixes our problems.