Closed jeromekelleher closed 5 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Cool, looks like this builds! @duncanmmacleod, would you mind trying this out on your local build to see if it fixes your linking problems?
@isuruf, what do you think, are you OK with changing the linking like this?
If we agree this is a good way to go I'll render the feedstock later before merging. Just wanted to keep the diff minimal for review purposes for the moment.
@jeromekelleher, this failed to link for me, much earlier than it used to:
dyld: Library not loaded: @rpath/libgsl.23.dylib
Referenced from: /Users/duncan/opt/miniconda3/conda-bld/lal_1545399317005/work/./conftest
Reason: image not found
@jeromekelleher, this failed to link for me, much earlier than it used to:
Ah OK, looks like there's some mac stuff going on. It was worth a try anyway. Let's see what the others think --- probably your PR is the way to go.
Looks like PR ( https://github.com/conda-forge/gsl-feedstock/pull/37 ) was merged. Is this still needed?
Closing this as #37 fixes our problems.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Following up on #37, try to resolve linkage errors in #34 by using the recommended recipe for linking GSL against alternative BLAS implementations.
@duncanmmacleod: I just thought I'd try this out and see what breaks.