Ensure that on Windows the public symbols of the shared library can be used

conda-forge / gsl-feedstock

A conda-smithy repository for gsl.

BSD 3-Clause "New" or "Revised" License

6 stars 18 forks source link

Closed traversaro closed 3 years ago

traversaro commented 4 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

traversaro commented 4 years ago

@conda-forge-admin, please rerender

traversaro commented 4 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 3 years ago

The PR is finally ready @conda-forge/gsl . It fixes https://github.com/conda-forge/gsl-feedstock/issues/50 using the same strategy used in vcpkg. The PR was previously not working due to https://github.com/conda-forge/autotools_clang_conda-feedstock/issues/13 , but now that problem is solved.

traversaro commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

traversaro commented 3 years ago

As in https://github.com/conda-forge/gsl-feedstock/pull/54, I am not sure why the drone build is failing, but it also failing with the recipe in the master branch.