search

conda-forge / gstreamer-feedstock

A conda-smithy repository for gstreamer.
BSD 3-Clause "New" or "Revised" License
9 stars 28 forks source link

Update recipe to use the latest version. #11

Closed matham closed 5 years ago

matham commented 6 years ago

I'm copying the relevant sections from the anaconda build source, which already builds the latest version. Hopefully the CI will all work.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ccordoba12 commented 6 years ago

@conda-forge-admin, please rerender

matham commented 6 years ago

I copied it over from the anaconda recipe which builds it for osx and linux. So its supposed to work on osx as well. I guess something is wrong with how I transcribed it.

On Tue, May 29, 2018, 7:20 PM Carlos Cordoba notifications@github.com wrote:

@ccordoba12 commented on this pull request.

In recipe/meta.yaml https://github.com/conda-forge/gstreamer-feedstock/pull/11#discussion_r191603519 :

url: https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-{{ version }}.tar.xz sha256: {{ sha256 }}

build:

  • skip: true # [win or osx]
  • number: 2
  • skip: true # [win]

Why this shouldn't be skipped for macOS?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/conda-forge/gstreamer-feedstock/pull/11#pullrequestreview-124205778, or mute the thread https://github.com/notifications/unsubscribe-auth/ABkW_jgVZ655uPquZUSGKso6mrS0IXLKks5t3dekgaJpZM4USUoh .

matham commented 6 years ago

It managed to build, but errored out on the linux test with 

gst-inspect-1.0: symbol lookup error: /home/conda/feedstock_root/build_artifacts/gstreamer_1527668447365/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/bin/../lib/libgstreamer-1.0.so.0: undefined symbol: g_cclosure_marshal_generic

On osx the tests failed with 

gst-inspect-1.0 --version
dyld: Library not loaded: @rpath/libgobject-2.0.0.dylib
  Referenced from: /Users/travis/miniconda3/conda-bld/gstreamer_1527668937920/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/bin/gst-inspect-1.0
  Reason: image not found
/Users/travis/miniconda3/conda-bld/gstreamer_1527668937920/test_tmp/run_test.sh: line 7: 20685 Trace/BPT trap: 5       gst-inspect-1.0 --version

I'm not really sure how to fix it.

ccordoba12 commented 6 years ago

@matham, please restore the linux and osx selectors since Ray is going to take care of that.

mariusvniekerk commented 5 years ago

For this to work you need to add a few more things from host to run as well. Conda-forge does not have run_exports for all upstream things yet.

ocefpaf commented 5 years ago

Thanks @matham. All the changes here should be covered in #17. Let me know if you still need anything from this PR though.