Build 19.8.0 - Githubissues

conda-forge / gunicorn-feedstock

A conda-smithy repository for gunicorn.

BSD 3-Clause "New" or "Revised" License

0 stars 13 forks source link

Build 19.8.0 #14

Closed rjurney closed 5 years ago

rjurney commented 5 years ago

Checklist

[*] Used a fork of the feedstock to propose changes
[*] Bumped the build number (if the version is unchanged)
[*] Reset the build number to 0 (if the version changed)
[*] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
```
@conda-forge-admin please rerender
```
[*] Ensured the license file is being packaged.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Whenever possible python packages should use pip. See https://conda-forge.org/docs/maintainer/adding_pkgs.html#use-pip

rjurney commented 5 years ago

@kwilcox @daf @jakirkham @sodre it looks like everything passed. Is there anything more that I need to do?

daf commented 5 years ago

@rjurney you're downgrading from 19.9.0 to 19.8.0?

rjurney commented 5 years ago

@daf superset 0.31 uses 19.8.0, so yes. I need that version published on conda-forge to install its prerequisites with conda. If you accept the pull into a new 19.8.0 branch it should build and push it out without replacing the old one?

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 5 years ago

@rjurney assuming you are not going to maintain the older version we can merge this and let be bot update it to the latest version again. However, if ou do want to maintain this older version you will need to send that to a branch.