search

conda-forge / gz-common-feedstock

A conda-smithy repository for gz-common.
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Rebuild for assimp 5.4.3 #45

Closed regro-cf-autotick-bot closed 1 month ago

regro-cf-autotick-bot commented 1 month ago

This PR has been triggered in an effort to update assimp543.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

traversaro commented 1 month ago

The failure is due to https://github.com/gazebosim/gz-common/issues/633 that was fixed in https://github.com/gazebosim/gz-common/issues/634, let's backport that patch.

Tobias-Fischer commented 1 month ago

Hi @traversaro - I fixed the patch for v5. However, I noticed this in the v5 branch: https://github.com/gazebosim/gz-common/blob/2faf830f480aba419d3dade55dad731fdf147add/graphics/src/AssimpLoader.cc#L659-L660

That comment (and the 1.0 - Y) have disappeared in v6. I am not sure if v5 needs the 1.0 - Y or not .. do you happen to know any more?

traversaro commented 1 month ago

I am not sure, perhaps we can just monitor https://github.com/gazebosim/gz-common/pull/641 and backport it once it has been cleaned up?

Tobias-Fischer commented 1 month ago

Looks like this did the trick - what do you think @traversaro?

github-actions[bot] commented 1 month ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!