h5py v3.12.0 - Githubissues

regro-cf-autotick-bot commented 1 month ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

[ ] Dependencies have been updated if changed: see upstream
[ ] Tests have passed
[ ] Updated license if changed and license_file is packaged

Information about this PR:

Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.
The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11044399665 - please use this URL for debugging.}

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

No valid build backend found for Python recipe for package h5py using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

jakirkham commented 1 month ago

@conda-forge-admin , please restart CI

jakirkham commented 1 month ago

Seeing this error on CI:

  building 'h5py.h5t' extension
  arm64-apple-darwin20.0.0-clang -fno-strict-overflow -Wsign-compare -Wunreachable-code -DNDEBUG -O2 -Wall -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -isystem /Users/runner/miniforge3/conda-bld/h5py_1727320470174/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/include -arch arm64 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -isystem /Users/runner/miniforge3/conda-bld/h5py_1727320470174/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/include -arch arm64 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -isystem /Users/runner/miniforge3/conda-bld/h5py_1727320470174/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/include -fdebug-prefix-map=/Users/runner/miniforge3/conda-bld/h5py_1727320470174/work=/usr/local/src/conda/h5py-3.12.0 -fdebug-prefix-map=/Users/runner/miniforge3/conda-bld/h5py_1727320470174/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac=/usr/local/src/conda-prefix -D_FORTIFY_SOURCE=2 -isystem /Users/runner/miniforge3/conda-bld/h5py_1727320470174/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/include -mmacosx-version-min=11.0 -mmacosx-version-min=11.0 -DH5_USE_110_API -DH5Rdereference_vers=2 -DNPY_NO_DEPRECATED_API=0 -I./h5py -I/Users/runner/miniforge3/conda-bld/h5py_1727320470174/_build_env/include -I/Users/runner/miniforge3/conda-bld/h5py_1727320470174/work/lzf -I/Users/runner/miniforge3/conda-bld/h5py_1727320470174/work/lzf/lzf -I/Users/runner/miniforge3/conda-bld/h5py_1727320470174/_build_env/venv/lib/python3.12/site-packages/numpy/_core/include -I/Users/runner/miniforge3/conda-bld/h5py_1727320470174/_build_env/venv/lib/python3.12/site-packages/mpi4py/include -I/Users/runner/miniforge3/conda-bld/h5py_1727320470174/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/include/python3.12 -c /Users/runner/miniforge3/conda-bld/h5py_1727320470174/work/h5py/h5t.c -o build/temp.macosx-11.0-arm64-cpython-312/Users/runner/miniforge3/conda-bld/h5py_1727320470174/work/h5py/h5t.o
  /Users/runner/miniforge3/conda-bld/h5py_1727320470174/work/h5py/h5t.c:18595:20: error: use of undeclared identifier 'h5py_size_n256'
   18595 |     __pyx_v_size = h5py_size_n256;
         |                    ^
  /Users/runner/miniforge3/conda-bld/h5py_1727320470174/work/h5py/h5t.c:18604:21: error: use of undeclared identifier 'h5py_offset_n256_real'
   18604 |     __pyx_v_off_r = h5py_offset_n256_real;
         |                     ^
  /Users/runner/miniforge3/conda-bld/h5py_1727320470174/work/h5py/h5t.c:18613:21: error: use of undeclared identifier 'h5py_offset_n256_imag'
   18613 |     __pyx_v_off_i = h5py_offset_n256_imag;
         |                     ^
  3 errors generated.

These variables would be undefined if COMPLEX256_SUPPORT is False. However the code using them shouldn't be generated if COMPLEX256_SUPPORT is False. So it is unclear why this code is emitted and these values are still undefined. Or for that matter why this comes up in this release

This looks similar to some past issues. However those all appear to be closed:

There was a 3.12.1 patch release right after 3.12.0, but that is only fixing Windows wheels IIUC: https://github.com/h5py/h5py/issues/2505

While there are a couple minor changes to h5t.pyx file, none of those changes appear relevant (unless I'm missing something?)

Could this be a Cython bug, a change in our build tooling somewhere, a change on macOS Azure builds, or something else?

tacaswell commented 1 month ago

https://github.com/h5py/h5py/pull/2482 and https://github.com/h5py/h5py/pull/2483 are probably related.

My guess is that there is something is going wrong with cross-platform builds and we are sorting out what is supported on a host system and the failing to build under the rules of the target platform?

hmaarrfk commented 2 weeks ago

Both of those seem to have been included in the 3.12.1 release but it is still failing in: https://github.com/conda-forge/h5py-feedstock/pull/147

lets close this PR in favor of

https://github.com/conda-forge/h5py-feedstock/pull/147 or https://github.com/conda-forge/h5py-feedstock/pull/146

tacaswell commented 2 weeks ago

@hmaarrfk Sorry, I meant those are a likely cause not the likely fix!

hmaarrfk commented 2 weeks ago

Ohh. I see. Yeah..... I'm puzzled too.

I feel like we should be able to support complex numbers on osx right????

conda-forge / h5py-feedstock

h5py v3.12.0 #142