Add MPI variants - Githubissues

conda-forge / h5utils-feedstock

A conda-smithy repository for h5utils.

BSD 3-Clause "New" or "Revised" License

0 stars 7 forks source link

Add MPI variants #6

Closed ChristopherHogan closed 5 years ago

ChristopherHogan commented 5 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ChristopherHogan commented 5 years ago

@minrk, thanks for your work on MPI variants. I'm trying it out here. Does everything look correct?

minrk commented 5 years ago

Does everything look correct?

I believe so!

minrk commented 5 years ago

Ah, while the metadata update looks right, does build.sh also need updating to set the flag? It's probably worth adding specific tests to verify that the mpi builds work right.

ChristopherHogan commented 5 years ago

Of course! Thanks for catching that. I see in hdf5-feedstock that the mpi variable is available in build.sh. How is that accomplished? Does setting mpi in meta.yaml via jinja automatically make mpi available in build.sh?

minrk commented 5 years ago

All the variables in conda_build_config.yaml show up as environment variables in build.sh.