search

conda-forge / hdf4-feedstock

A conda-smithy repository for hdf4.
BSD 3-Clause "New" or "Revised" License
1 stars 17 forks source link

Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #23

Closed regro-cf-autotick-bot closed 5 years ago

regro-cf-autotick-bot commented 6 years ago

It is likely this feedstock needs to be rebuilt. Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children: hdfeos2 libgdal libnetcdf ncl pyhdf And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues!

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 6 years ago

The recipe is not virtually identical to AR but it is failing on OS X+gcc.

It would be nice to get a macOS expert to take a look here.

msarahan commented 5 years ago

The mac error with the new compilers points to problems with the test binaries not having their RPATH stuff fixed up. That was the purpose that DYLD_FALLBACK_LIBRARY_PATH served, but I'm pretty sure that Apple broke that with SIP.

An example of how to add the appropriate flag is at https://github.com/AnacondaRecipes/openblas-feedstock/blob/master/recipe/build.sh#L21

Just make sure that flag is being applied when ncgen is compiled. The build log shows that that -Wl,-rpath is in LDFLAGS, but it probably should be in CPPFLAGS instead. That's "C preprocessor flags" not "C++ flags" - the latter is CXXFLAGS.

Windows looks quite a bit worse. I'm sorry I don't have more time to look into that one. Since the file that is causing problems is one that is being patched (https://ci.appveyor.com/project/conda-forge/hdf4-feedstock/builds/19308163/job/fs66l6tbncao9pui#L282), I'd start by double-checking that patch (error_top.diff) and making sure that it is doing appropriate things on Windows, and not using any macros or symbols that are not provided by the annoyingly-not-standard MSVC.

ocefpaf commented 5 years ago

Thanks @msarahan! That gives me some things to work with for a while :smile:

CPPFLAGS instead. That's "C preprocessor flags" not "C++ flags" - the latter is CXXFLAGS.

Even though I know that I always read it in my mind C++ :rofl:

isuruf commented 5 years ago

@ocefpaf, it's something to do with the CFLAGS, CPPFLAGS, CXXFLAGS or LDFLAGS.

If I do,

unset CXXFLAGS
unset CFLAGS
unset LDFLAGS
unset CPPFLAGS

export CPPFLAGS="-I${PREFIX}/include"
export LDFLAGS="-L${PREFIX}/lib -Wl,-rpath,${PREFIX}/lib"

it works. I don't have a OSX machine to debug this on. Somebody will have to remove flags from the compiler one by one to see which flag is causing this error.

ocefpaf commented 5 years ago

@ocefpaf, it's something to do with the CFLAGS, CPPFLAGS, CXXFLAGS or LDFLAGS.

Thanks @isuruf! I'll play with those on my Travis-CI instance and report back.

ocefpaf commented 5 years ago

Thanks @isuruf, @marcelotrevisani, and @msarahan! :tada: