Aarch - Githubissues

conda-forge / hdf4-feedstock

A conda-smithy repository for hdf4.

BSD 3-Clause "New" or "Revised" License

1 stars 17 forks source link

Aarch #29

Closed hmaarrfk closed 3 years ago

hmaarrfk commented 4 years ago

Closes #28 Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 4 years ago

What does error: unknown type name 'uintn'; did you mean 'uint'? mean?

hmaarrfk commented 4 years ago

seems like it is some custom defined datatypes by the hdf group

https://github.com/cedadev/jasmin_scivm/blob/master/SOURCES/hdf-4.2.4-s390.patch

hmaarrfk commented 4 years ago

I think the tests are failing on ppc64le due to some memory stuff.

Running linux locally on my machine made my comptuer basically halt for 60 seconds during the test section.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

hmaarrfk commented 4 years ago

nice drone got triggered. time to see if these bugs are real, are just qemu related.

hmaarrfk commented 4 years ago

It seems that HDF4 didn't have the correct settings or tests for ppc64le

>>> External value 57 was expecting 57 got 956301312

is basically

In [3]: hex(956301312)                                                                                   
Out[3]: '0x39000000'

In [4]: hex(57)                                                                                          
Out[4]: '0x39'

Should we care about fixing this?

This seems out of scope for conda-forge, and out of scope for hdf4 (Seeing as hdf5 now exists)

hmaarrfk commented 4 years ago

it seems debian did a good job packaging these for ppc64le and aarch64

https://salsa.debian.org/debian-gis-team/hdf4/-/tree/master/debian%2Fpatches

I wonder if there is a way to upstream these patches.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

gillins commented 3 years ago

@hmaarrfk can we assume that hdf4 isn't going to run on aarch64 etc easily...?

hmaarrfk commented 3 years ago

We've skipped it as a dependency in an other package. hdf5 only on alternative architectures.

matthiasdiener commented 3 years ago

Aarch support has been added via #36.