Closed duncanmmacleod closed 2 years ago
conda-forge-linter
commented
2 years ago Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
duncanmmacleod
commented
2 years ago @timtheisen @jasoncpatton the macOS builds are failing with:
In file included from /Users/runner/miniforge3/conda-bld/htcondor-build_1660217934374/work/src/condor_utils/condor_threads.cpp:233:
/Users/runner/miniforge3/conda-bld/htcondor-build_1660217934374/work/src/condor_utils/threads_implementation.h:36:29: error: typedef redefinition with different types ('unsigned long' vs '__darwin_pthread_t' (aka '_opaque_pthread_t *'))
typedef long unsigned int pthread_t;
^
/Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/sys/_types/_pthread_t.h:30:29: note: previous definition is here
typedef __darwin_pthread_t pthread_t;
^
1 error generated.cmake 3.24.0 removed CMAKE_HAVE_PTHREAD_H from FindThreads, it's now in CMakeBackwardsCompatibilityCXX.cmake. So I am going to pin to cmake <3.24.0a0 (my preferred no thought solution) until this is fixed upstream. I will open a jira ticket.
duncanmmacleod
commented
2 years ago duncanmmacleod
commented
2 years ago @timtheisen, @jasoncpatton, I think this is ready to go, any other changes required?
Checklist
0(if the version changed)conda-smithy(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)