search

conda-forge / icu-feedstock

A conda-smithy repository for icu.
BSD 3-Clause "New" or "Revised" License
1 stars 21 forks source link

Attempt to fix VS2008 build #16

Closed gillins closed 7 years ago

gillins commented 7 years ago

Seems builds for Python 2.7 were failing as we weren't catching the fact that msbuild was exiting with an error (see https://ci.appveyor.com/project/conda-forge/icu-feedstock/build/1.0.62/job/rh4vfnnyaogx8b8p#L351).

The packages were being created, but they were empty....

This PR adds more tests and also uses the same trick as xerces-c to copy a more recent `msbuild' which then drives the VS2008 compiler happily.

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 7 years ago

The packages were being created, but they were empty....

Sorry. I should pay more attention to Windows packages.

gillins commented 7 years ago

I'd appreciate any comments people have on this.

The msbuild approach only seemed to work for VS2014. I've use the approach recommended here: https://wiki.qt.io/Compiling-ICU-with-MSVC , although I had to make some modifications. I think @msarahan tried this ages ago?

Anyway, I seem to have it working now for both VS2008 and VS2014.

ocefpaf commented 7 years ago

Anyway, I seem to have it working now for both VS2008 and VS2014.

:+1:

@msarahan or @mingwandroid could any of you take a quick look before we merge?

gillins commented 7 years ago

ping

ocefpaf commented 7 years ago

@gillins if @msarahan or @mingwandroid are too busy to take a look at this we can merge it and hope for the best :wink: (worst case scenario we will need to pull the packages from the channel.)

ccordoba12 commented 7 years ago

Let's merge it. The proof of fire for this is Qt5 :-)

ocefpaf commented 7 years ago

Thanks @ccordoba12!

gillins commented 7 years ago

Thanks guys. There might be py27 versions of packages out there that need rebuilding to get their icu support properly working (which weren't working at all before) but I guess we can do that as needed.