conda-forge / icu-feedstock

A conda-smithy repository for icu.
BSD 3-Clause "New" or "Revised" License
1 stars 21 forks source link

Fix the Windows package #26

Closed pkgw closed 5 years ago

pkgw commented 5 years ago

The build.sh was not in set -e mode, which masked the fact that the Windows installation step wasn't fully completing (log, line 2859). This PR fixes that, and fixes the Windows install by creating a needed directory before the build.

I've re-applied the patch from @xhochy to fix conda-build to version 3.17.8, which was blown away by the rerender; if it's not still needed, we can take it out.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.