conda-forge / idyntree-feedstock

A conda-smithy repository for idyntree.
BSD 3-Clause "New" or "Revised" License
3 stars 7 forks source link

ENH updated version to 12.0.0 #81

Closed conda-forge-admin closed 7 months ago

conda-forge-admin commented 7 months ago

Hi! This is the friendly automated conda-forge-webservice.

I've started a version update as instructed in #80.

I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!

Fixes #80

conda-forge-webservices[bot] commented 7 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 7 months ago

Now all the jobs fail on the Visualizer test:

56/66 Test #56: UnitTestVisualizer ....................................***Failed    0.93 sec
[ERROR] Visualizer :: init : Could not create window
[ERROR] Visualizer :: addModel : Error in initializing Irrlicht device
%SRC_DIR%\src\visualization\tests\VisualizerUnitTest.cpp:17 : assertTrue failure

Interestingly, similar tests used to work fine before this PR, not sure if the modifications done to the tests by @S-Dafarra created this problem. However, the test was never run in the iDynTree CI (see https://github.com/robotology/idyntree/issues/808), so I am surprise that instead we were running it in conda-forge and it was working. Anyhow, at this point I think it make sense to just skip it.

github-actions[bot] commented 7 months ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

S-Dafarra commented 7 months ago

Now all the jobs fail on the Visualizer test:

56/66 Test #56: UnitTestVisualizer ....................................***Failed    0.93 sec
[ERROR] Visualizer :: init : Could not create window
[ERROR] Visualizer :: addModel : Error in initializing Irrlicht device
%SRC_DIR%\src\visualization\tests\VisualizerUnitTest.cpp:17 : assertTrue failure

Interestingly, similar tests used to work fine before this PR, not sure if the modifications done to the tests by @S-Dafarra created this problem. However, the test was never run in the iDynTree CI (see robotology/idyntree#808), so I am surprise that instead we were running it in conda-forge and it was working. Anyhow, at this point I think it make sense to just skip it.

I think it is due to the fact that it tries to create a Window with GLFW. One thing to try would be to run in an emulated x environment, as in https://github.com/ami-iit/yarp-device-openxrheadset/blob/ad4ec150174ce527a2af0e909196c25350374c9b/.github/workflows/ci.yml#L136-L151

Still, no idea why it was working before

traversaro commented 7 months ago

Still, no idea why it was working before

Indeed. Anyhow, we can use https://github.com/robotology/idyntree/issues/808 to track the problem, for sure we can't have a test in the conda-forge CI if we do not have it enabled in the upstream CI.