conda-forge / imagecodecs-feedstock

A conda-smithy repository for imagecodecs.
BSD 3-Clause "New" or "Revised" License
3 stars 9 forks source link

imagecodecs v2021.2.26 #25

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version. Checklist before merging this PR:
    • [ ] Dependencies have been updated if changed: see upstream
    • [ ] Tests have passed
    • [ ] Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/605121399, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

csachs commented 3 years ago

The tests under Windows fail exactly like in the last build, just test_imagecodecs.py reports the status in this version, it didn't before: https://github.com/cgohlke/imagecodecs/blob/01e7bff6d2bd844f4f782fcee452be9e662b545e/tests/test_imagecodecs.py#L2367 OpenMP with MSVC/Windows seems to be problematic, I've read; and if upstream doesn't have it, we can't do much here. I'd say we set SKIP_OMP=1 under Windows for the tests…https://github.com/cgohlke/imagecodecs/blob/01e7bff6d2bd844f4f782fcee452be9e662b545e/tests/test_imagecodecs.py#L1646

Should I take care of this @hmaarrfk ?

By the way, does anyone know why the zfp feedstock is marked as archived?

hmaarrfk commented 3 years ago

https://github.com/conda-forge/zfpy-feedstock

Is the CI problematic or is all of OMP on windows broken?

If you wanted to help add your comment to the build. Along with the necessary flags, that would help :)

cgohlke commented 3 years ago

OpenMP with MSVC/Windows seems to be problematic

I have been using OpenMP with MSVC on Windows in Cython and C++ modules without major issues. Set SKIP_OMP=1 if zfp was built without OpenMP.

csachs commented 3 years ago

I've opened https://github.com/conda-forge/zfpy-feedstock/pull/16 . My initial guess of OpenMP problems was founded by a quick search revealing most MSVC versions only supporting OpenMP 2.0 … but that seems to be fine for ZFP, as I've tried in the meantime. So unless there are any particular reasons why upstream zfp was built without it, the imagecodec's tests should be good once upstream zfp is rebuilt with OpenMP enabled.

hmaarrfk commented 3 years ago

Is there a way to detect if zfp was compiled with OMP dynamically?

csachs commented 3 years ago

Looking through the zfp source … there doesn't seem to be a way to query it, except for "trial-and-error": https://github.com/LLNL/zfp/blob/dd174cd21ad9366a7fda41ed79ed63ca076a4313/src/zfp.c#L841-L866 As suggested in the manual https://zfp.readthedocs.io/en/release0.5.5/execution.html#setting-the-execution-policy So setting an execution policy with OpenMP (or e.g. CUDA) enabled, but no support compiled in, will yield false. But it's little different from trying it, and failing with an error. If that should be queryable beforehand, on the imagecodecs-side, a query function which just create an empty stream, tries to set the specific execution policy, free the stream again and return success or failure, could be added. (Or an API to get the compiled in execution policies could be added to upstream zfp …)

csachs commented 3 years ago

@conda-forge-admin, please restart ci

csachs commented 3 years ago

I'd say we merge this now to have packages for this version, then address this single test problem of https://github.com/conda-forge/imagecodecs-feedstock/pull/26 under macOS of the next version.